".. What seems to be a problem?"

I wanted to know if there are any best practice's for this, or if indeed I'm going about the process in the right fashion. I'm hoping someone has done something similar and could therefore let me know if I'm right in the first instance, how they've coded their example, and whether or not there are any pitfalls that I should be aware of.

Regards