Jim,
>Interesting... I expected your main criticism to be repeated code if used in more than 1 place.
There would be that too if you set those variables in more than one place. That destroys code maintainability.
>Personally, in these days of large RAM I have little concern for memvar consumption.
memvar consumption != memory consumption. VFP is still limited by MVCOUNT, which is someone is already running near the limit and they call into some blackbox Word automation code you've created their app can crash.
>And my suspicion is that execution speed would be little different between the two because I assume that any "constants" actually end up in (what we called in mainframe days) the "literal pool", resulting in similar execution as using a memvar. And, again, today's processors are so fast that I concentrate speed issues primarily on external data access/update and not on internal memory fetching.
Using memvars you make the end user spend the CPU cycles every execution of that code. #defines make only one CPU hit and that's on the programmers machine at compile time.