>Thanks for the feedback Nicholas. In this case, by "maintenance" they mean the ability to keep enhancing. There are ongoing requests for additional features. The bug history, from what I know so far, is somewhere in the middle from "every day" to "no problems", maybe something along the lines of a several support calls a week spread out over several hundred installations. In this case, I am being asked, therefore, to specifically look at the quality of the code, maybe not every line, but a big picture view.
>

Still, your idea of "normal change" may differ from them. I'd look for No. of Parameters in methods/functions:
too many parameters smell of "Eierlegegende Wollmilchsau" (does everything, but nothing perfect).

I prefer rather flat class hierarchies and a few objects coupled tigether vias factory: great flexibility
without the brittleness of deep classes, where you need to refactor often.

Ask for their favorite pattern and why they use it in the app.
Try PDM, doc wizard, one app on vfpX and a tool to find undeclared vars.

my 0.02 EUR

thomas