Hi all,

I have this method I am refactoring for various reasons. There is a lot of nesting and plan to remove some of it. I am wondering about this intital test inside of a lock statement and wonder if it would be safe to move it outside of the lock construct.

This is what it looks like now.

public void FindActiveWebService()
{
    lock (FindWebServiceSync)
    {
        if (!IsFindingActiveWebService)
        {
            IsFindingActiveWebService = true;
            try
            {
                // Lots of crappy code and nested code in here with loops and such.
                // Planning to refactor all this junk.
            }
            finally
            {
                IsFindingActiveWebService = false;
            }
        }
    }
}

Wondering if it would be just as safe to do this and remove the extra if structure.

public void FindActiveWebService()
{
    // Moved outside the lock
    if (IsFindingActiveWebService)
        return;

    lock (FindWebServiceSync)
    {
        IsFindingActiveWebService = true;
        try
        {
            // Lots of crappy code and nested code in here with loops and such.
            // Planning to refactor all this junk.
        }
        finally
        {
            IsFindingActiveWebService = false;
        }
    }
}

Thanks for any thoughts.
Timothy