>>>>As to the parameter, my thought was that by using a struct you are passing in a single parameter object and that object will have fields of only the proper types. While it is true that does not otherwise validate the values, it does go a long way to remove param checking from the responsibility of the method it is passed to and can be handled elsewhere as the params are assmebled.
>>>>
>>>>The idea of passing in something like XML as a param sets my teeth on edge. ( though I suppose you could validate its creation elsewhere, you still end up parsing it out in a way that makes the receiving method clutter with stuff that would have to be duplicated anywhere that param was used.
>>>
>>>The XML string with parameters is passed from another application (written in C++) which we're not going to change. We're only re-writting one piece which is currently in VFP those job is to accept these parameters passed as XML (along with the method name in func MethodName /func) and execute it and return back either XML or a string.
>>>
>>>So, C# dll will receive the parameters the same way (as XML string) and needs to produce exactly the same output as VFP applicaton was producing.
>>
>>
>>Sure, but you can still receive the XML in your method, parse it into an object, and then pass the object to another method, thereby delegating the actual business logic to one method and the XML interface to that logic in another method.
>
>Can you please clarify your point with some code?
>
>Right now we have several helper methods - one to verify parameters and returned types and another is to retrieve parameter by name (as a string) from that Dictionary of parameters.
>
>So, all the methods currently have this as a start:
>
>

>internal static String GetGuestLiabilityAcceptance(Dictionary<String, String> parameters)
>        {
>            Logging.Log(1, "Entering GetGuestLiabilityAcceptance");
>
>            List<String> requiredParameters = new List<String>() { "tnGuestNo" };
>            //always required parameters (but not used)          { "tcSalesPoint", "tcOperator" };
>            
>            HashSet<String> availableReturnTypes = new HashSet<String>(StringComparer.OrdinalIgnoreCase) { "STR", "ADO", "XML", "XM2" };
>
>            String messageText = "";
>            Int32 errorValue = 0;
>            Int32 statusCode = 0;
>
>            // If all necessary parameters are present and valid, proceed...
>            if (Functions.CheckRequiredParameters(parameters, requiredParameters, availableReturnTypes, out statusCode, out messageText))
>            {
>                // Parse out the parameters
>                String tcGuestNo = Functions.GetParameterValue(parameters, "tnGuestNo");
>            
>                Decimal guestNo;

>
>How do you suggest to change the above?
>
>Thanks again.



Well, I don't know specifically how you'd parse the XML in C# (cause I don't use it) but it would be roughly something like this:

GetGuestLiabilityAcceptance( "<config setting='true' />" );

Then you make a config class:

class Config {
Boolean setting = false;
}

So now in your function:

GetGuestLiabilityAcceptance(String myString){
// just pseudo code rememebr
XmlParser xmlParser = makeXmlParser(mystring);
Config myConfig = new Config();
myConfig.setting = xmlParser.getAttribute("setting")

// check to make sure you've for something
if (myConfig.setting == null){
return false;
//or better...
throw new InvalidArgumentException();
//or even better...
throw new NullPointerException();
}

// otherwise hand the config object off to your class
return GetGuestLiabilityAcceptance2(myConfig);

}


This way you can write GetGuestLiabilityAcceptance2 (or GetGuestLiabilityAcceptance on another class) to do what it has to do and be completely ignorant about whether the original parameter was XML, or JSON, or whatever you map to the Config object.