>>I don't wish to argue with anybody here, I respect your views too much, but I don't think you should make assumptions about somebody's programming style/ability/whatever, without more detailed knowledge.
>
>Since I started this, let me finish it.
>
>There are two points to be made here. First, it was the very nature of the question that indicated that the point about the breakdown of functional cohesion was a necessary addition. While insufficient information existed to accurately make any sort of determination of the programmer's skill level, certain (perhaps erroneous) conclusions may have been arrived at. If they were incorrect or not is irrelevant.
>
>Second, we're not operating in a vacuum here. The original poster was not and will not be the only person to read it. Someone else, with less experience and knowledge may someday come along, and take a look, and might some dreadful design decisions based simply on the problem and the solution. It was, and is important to point out not only the solutions to problems, but any potential dangers that might exist with a given solution. In this case, the potential for later problems is quite large.
>
>And with that, this should be EOT.

Unfortunately I disagree with that point of view. In the original posting there was not enough information to determine if anything would be done to affect functional cohesion.

If you look at any of the problems posted here, you could come up with any number of valid reasons why the problem could cause bigger problems, you are only limited by your imagination. Pointing those out may be valuable to other programmers - but of no relevance to the original programmer.

I don't think it benefits anyone to start giving advice on what you imagine they may be doing. If there's evidence that they may be doing something wrong, then point it out. If you only think they might be doing something wrong, ask if that's what they are intending to do. Do not tell someone they are doing something wrong based only on your own imagination. It's just a matter of courtesy.