Plateforme Level Extreme
Abonnement
Profil corporatif
Produits & Services
Support
Légal
English
Conditional Best Practice
Message
 
 
À
26/07/2001 14:44:45
Nancy Folsom
Pixel Dust Industries
Washington, États-Unis
Information générale
Forum:
Visual FoxPro
Catégorie:
Codage, syntaxe et commandes
Divers
Thread ID:
00535738
Message ID:
00535977
Vues:
13
Hi Nancy,

It's a quite complicated matter is dealing with persons and programs. For instance, I was looking for my colleague's code in the application, what was recently turned to me. She used this approach, when she needed to determine, if the passed string is in a table, she scanned the table checking for occurance. I replaced this code with seek function and just asked her precisely:
BTW, in address standardization: why do you scan StSuffix and StrtDirnl tables instead of divide streets by words and check each word against this table, applying some additional rules, if needed? It should work much faster and the algorithms would be clear.
Now I have to re-write these methods by myself.


Of course, I didn't get any answer, but my manager came to my desk and tried to explain, that it's not pollite to show, that somebody makes something "stupid". Well, if I see, that the code is not efficient enough, why I can not tell the person about its unefficiency? Why it's considered as an offense?

I'm afraid, I didn't make freinds making these comments, but I could not understand one simple thing: it's obviously, that the code is not efficient. Why she didn't change it by herself during these two years?


>>>You could make the property a part of the class you're using and check it's value rather than PEMSTATUS() which has got to be a lot of overhead.
>>>
>>>So, have .cSourceAlias = "" in the base class. Then you can check IF EMPTY(.cSourceAlias); *!* We need to initialize()
>
>>Seems so simple when someone else says it... It worked great; eliminated about 40 lines of code and simplified any maintenance I may need to do in the future.
>
>Cool! Sometimes it just takes a fresh look. I'm happy I could offer some help.
>
>> Thanks! BTW, just wanted to say that you've taken some grief lately and it was, as Jeff and David and others have pointed out, unjust. I've always apprectiated your advice and never felt the delivery was anything but honest.
>
>I appreciate the support. While I regret misunderstanding, I've come to accept that human communication is messy. I used to think it was possible to communicate perfectly and I'd craft every comment and response so as to not offend, but still there were misunderstandings. I've also come to learn that sometimes people go out of their way to look for offense, and there just ain't nothing you can do about that. I know I do it sometimes, too. So, when other people do it, it's a good reminder to myself to not freak out everytime someone looks at me cross-eyed.
>
>Old age is a wonderful thing in many ways...despite the pain in my knees and grey hair. *g*
>
>< /questionable philosophical digression>
If it's not broken, fix it until it is.


My Blog
Précédent
Suivant
Répondre
Fil
Voir

Click here to load this message in the networking platform