No because it is not very efficient because your using precious ressources.

Use an INSERT query instead of opening a recordset.




>Guy,
>
>Is this code correct for retreving the data as a design point of view ?
>
>BR
>
>>>Hi All,
>>>
>>>I am getting an error with the following code, can any one advice me what is wrong in this code, the error I get on line "rstGuestBook.AddNew"
>>>the aim of this code is, will add a new record to my GuestBook.mdb File.
>>>
>>>this is the code:
>>>
>>>Set myConn = Server.CreateObject("ADODB.Connection")
>>>myConn.Open "2bs-GuestBook"
>>>mySql = "SELECT * FROM GuestBook"
>>>Set rstGuestBook = myConn.Execute(mySql)
>>>
>>>rstGuestBook.AddNew
>>>
>>>rstGuestBook("Nmae") = Request.Form("txtName")
>>>rstGuestBook("Email") = Request.Form("txtEmail")
>>>rstGuestBook("Company") = Request.Form("txtCompany")
>>>rstGuestBook("Url") = Request.Form("txtUrl")
>>>rstGuestBook("Comment") = Request.Form("txtComment")
>>>
>>>rstGuestBook.Update
>>>
>>>rstGuestBook.Close
>>>Set rstGuestBook = Nothing
>>>
>>>myConn.Close
>>>Set myConn = Nothing
>>>
>>>Response.Redirect("guest_book_Thanks.html")
>>>
>>>
>>>BR
>>
>>
>>Where's your connection string ?
>>
>>On a design point of view:
>>You should not open a recordset to add a new record. It waste precious ressources for no good reasons.
>>You should open you Connection and execute an INSERT query or open a Connection, create a Command object and call a store procedure.