>{snip}But coding can sometimes be a very personal thing and one coder's drink is another one's poison.{snip}
Absolutely agree.
We use formsets regularly and we have no problems with them. Our main use is to keep things like the query and detail forms in reports toghether. That can be accomplished with pageframes, but we like the possibility of keeping the query form sized to the needs of every query, and the detail form (always a grid or two) as big as possible.
Using pageframes would imply that in some cases the query page would have lots of blank space.
Formsets raises a bit the level of complexity because there is another lever of containership, but pageframes also do this.
Anyway, what we found is that is better to keep the component forms as classes. Coding right into the formsets can be confusing because the custom methods get at this outer level.
The only major drawback that we found in all this time (we use formset since VFP 3, around 7000 years ago) is that you can't subclass them, so we have a function that must to be called from the Formset's Load to perform the private datasession settings first than any other thing. And of course, you loss a LOT of possibilities not being able to subclass something.
Good luck.