Have you tried entering each line through the command window to isolate where it failed? Or write a standard error handler to tell you which line is breaking:

ON ERROR DO ErrorTrap WITH ERROR( ), MESSAGE( ), MESSAGE(1), PROGRAM( ), LINENO( )

PROCEDURE ErrorTrap (merror, mess, mess1, mprog, mlineno) &&----------
on error
if messagebox('Error number           :'+LTRIM(STR(merror))+chr(13);
              +'Error message          :'+ mess+chr(13);
              +'Line of code with error:'+mess1+chr(13);
              +'Line number of error   :'+LTRIM(STR(mlineno))+chr(13);
              +'Alias                  :'+alias()+chr(13);
              +'Order()                :'+Order()+chr(13);
              +'Program with error     :'+mprog,1+48,[Error Trapped!])=2
   cancel
else
   ON ERROR DO errhand WITH ERROR( ), MESSAGE( ), MESSAGE(1), PROGRAM( ), LINENO( )
endif
endproc

>I am trying to upload data from VFP tables into SQL server using ADO
>
>I can open the connection, but opening the recordset gives an error.
>
>My code is something like this.
>
>**
>local ERR
>on Error ERR = .T.
>With oNewphotoRS
> .ActiveConnection = oConnection
> .Source = "Photographers"
> .CursorLocation = adUseClient
> .LockType = adLockBatchOptimistic
> .CursorType = adOpenDynamic
> .CommandType = adcmdTable
> .Open()
>EndWith
>**
>IF Err
> WAIT WINDOW "Error opening recordset"
>ENDIF
>**
>
>What I am doing wrong here. I am using VFP 7.
>
>TIA
>
>Alhad