>Hi all,
>
>I have this method I am refactoring for various reasons. There is a lot of nesting and plan to remove some of it. I am wondering about this intital test inside of a lock statement and wonder if it would be safe to move it outside of the lock construct.

>Wondering if it would be just as safe to do this and remove the extra if structure.
>

>public void FindActiveWebService()
>{
>    // Moved outside the lock
>    if (IsFindingActiveWebService)
>        return;
>
>    lock (FindWebServiceSync)
>    {
>        IsFindingActiveWebService = true;
>        try
>        {
>            // Lots of crappy code and nested code in here with loops and such.
>            // Planning to refactor all this junk.
>        }
>        finally
>        {
>            IsFindingActiveWebService = false;
>        }
>    }
>}
>

Let's supposed IsFindingActiveWebService is false. One thread calls FindActiveWebService() and makes it past the return. At the same time, another thread calls this same code. It also makes it past this check. The first thread has locked FindWebServiceSync, so the other thread is currently blocked. It appears like the only reason for IsFinidingActiveWebService (if it's not used anywhere else) is to keep threads from piling up here under heavy loads (although you could do this with just the FindWebServicesSync by checking if it's locked).

( Ah, I just read you're reply & Vivs), yep, looks redundant.